fedora 23
race weakness #17

Weakness Breakdown

Definition:

A race condition exists when parallel code accesses shared data without proper coordination. An attack that uses a race-condition weakness takes advantage of the unsafe data access to manipulate how one of the parallel sections of code reacts. Even though each process runs as intended, the outcome is unexpected. For example, consider a bank service that depends on an encryption key that it reads from a known location. An independent cryptography service is responsible for generating the key and placing it where the bank is expected to read it in a timely manner. If the bank and cryptography services do not coordinate with each other, then the bank may read a blank encryption key before cryptography writes the key to the location. This can effectively turn off all encryption for the bank without either service, or the administrator, knowing that something has gone wrong.

Warning code(s):

This accepts filename arguments; if an attacker can move those files, a race condition results..

File Name:

c2esp-27/src/c2esp.c

Context:

The highlighted line of code below is the trigger point of this particular Fedora 23 race weakness.

 	}
}

FILE *OpenPbm(char *Name, int Width, int Height, int FullScale)
{
// Opens a pbm graphic file for writing. "P5" or "P4"
// If FullScale = 0, a P4 file (line art, 1 bit per pixel)
// If FullScale > 0, a P5 file (gray scale, 1 byte per pixel)

	FILE *Handle;
	remove(Name);
	Handle = fopen(Name, "w");
	if (Handle) 
	{
		if(FullScale == 0) fprintf(Handle, "P4\n%8d %8d\n", Width, Height);
		else if (FullScale > 0) fprintf(Handle, "P5\n%8d %8d %8d\n", Width, Height, FullScale);
		DoLogString("Opened %s\n", Name);
	}
	else DoLogString("Could not open %s\n", Name);
	return Handle;
}

void LetAllRead(char *Fname)
{
		chmod(Fname, S_IRUSR | S_IWUSR | S_IROTH ); //let anyone read it
}


void 
Terminate(cups_raster_t *ras,int fd,cups_dither_t **DitherState,cups_lut_t **Lut)
{
int CloseError, Col;

 /*
  * Close the raster stream... and the debug file
  */
 	cupsRasterClose(ras);
	DoLog("cups raster closed after %d sec\n",time(NULL)-StartTime,0);
  	if (fd != 0)   close(fd);
	if(JobFile != NULL)
	{
		CloseError = fclose(JobFile);
		DoLog("jobfile closed after %d sec with return value %d\n",time(NULL)-StartTime, CloseError);
	}

//free the dither states
  	for(Col = 0; Col < 4 ;++Col)
	{
		cupsDitherDelete(DitherState[Col]);
	  	cupsLutDelete(Lut[Col]);