fedora 24
crypto weakness #276

4

Weakness Breakdown


Definition:

This weakness involves creating non-standard or non-tested algorithms, using weak algorithms or applying cryptographic algorithms incorrectly. Algorithms that were once considered safe are commonly later found to be unsafe, as the algorithms were broken.

Warning code(s):

The crypt functions use a poor one-way hashing algorithm; since they only accept passwords of 8 characters or fewer and only a two-byte salt, they are excessively vulnerable to dictionary attacks given today's faster computing equipment.

File Name:

grive2-ae06eccb38b2fe250c9ddeac3e3973f80b8a0aa9/libgrive/src/http/Download.cc

Context:

The highlighted line of code below is the trigger point of this particular Fedora 24 crypto weakness.

 #include "Download.hh"
// #include "util/SignalHandler.hh"

#include "util/Crypt.hh"

// boost headers
#include <boost/throw_exception.hpp>
#include <boost/exception/errinfo_api_function.hpp>
#include <boost/exception/errinfo_at_line.hpp>
#include <boost/exception/errinfo_errno.hpp>
#include <boost/exception/errinfo_file_handle.hpp>
#include <boost/exception/errinfo_file_name.hpp>
#include <boost/exception/errinfo_file_open_mode.hpp>
#include <boost/exception/info.hpp>

#include <cassert>
#include <new>

#include <signal.h>

namespace gr { namespace http {

Download::Download( const std::string& filename ) :
	m_file( filename, 0600 ),
	m_crypt( new crypt::MD5 )
{
}

Download::Download( const std::string& filename, NoChecksum ) :
	m_file( filename, 0600 )
{
}

Download::~Download()
{
}

void Download::Clear()
{
	// no need to do anything
}

std::string Download::Finish() const
{
	return m_crypt.get() != 0 ? m_crypt->Get() : "" ;
}

std::size_t Download::Write( const char *data, std::size_t count )
{
	assert( data != 0 ) ; 

The registered trademark Linux® is used pursuant to a sublicense from the Linux Foundation, the exclusive licensee of Linus Torvalds, owner of the mark on a world­wide basis.