fedora 24
crypto weakness #304


Weakness Breakdown


This weakness involves creating non-standard or non-tested algorithms, using weak algorithms or applying cryptographic algorithms incorrectly. Algorithms that were once considered safe are commonly later found to be unsafe, as the algorithms were broken.

Warning code(s):

The crypt functions use a poor one-way hashing algorithm; since they only accept passwords of 8 characters or fewer and only a two-byte salt, they are excessively vulnerable to dictionary attacks given today's faster computing equipment.

File Name:



The highlighted line of code below is the trigger point of this particular Fedora 24 crypto weakness.

#include <sys/label.h>
#include <sys/audit.h>
#include <pwdadj.h>

/* Check password
 * Accepts: login passwd struct
 *	    password string
 *	    argument count
 *	    argument vector
 * Returns: passwd struct if password validated, NIL otherwise

struct passwd *checkpw (struct passwd *pw,char *pass,int argc,char *argv[])
  struct passwd_adjunct *pa;
  char *user = cpystr (pw->pw_name);
				/* validate user and password */
  struct passwd *ret =
    ((pw->pw_passwd && pw->pw_passwd[0] && pw->pw_passwd[1] &&
      !strcmp (pw->pw_passwd,(char *) crypt (pass,pw->pw_passwd))) ||
     ((pa = getpwanam (pw->pw_name)) &&
      pa->pwa_passwd && pa->pwa_passwd[0] && pa->pwa_passwd[1] &&
      !strcmp (pa->pwa_passwd,(char *) crypt (pass,pa->pwa_passwd)))) ?
	getpwnam (user) : NIL;
  if (user) fs_give ((void **) &user);
  return ret;

The registered trademark Linux® is used pursuant to a sublicense from the Linux Foundation, the exclusive licensee of Linus Torvalds, owner of the mark on a world­wide basis.